Frontend Mentor | QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  HTML 🏷️:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  Alt text 📷:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • The color of the paragraph element is unreadable because it is too light compared to its background. For example, change the color to hsl(220deg, 15%, 55%).

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 12 months ago

  Hello @AyamaneNouhair!

  Your project looks great!

  I wouldn't say it's an error, but I think there's a small detail that can help you to improve your project:

  • Check the font-weight and colors of the text. Make sure you import the font-family from Google Fonts with all the weights used in this project. I noticed that you set font-weight: 700; to your <h2>, but it's not applying.

  • Also, since every project should have a <h1> and that bold text is the most important content on the screen, you can replace your <h2> with a <h1>. You don't use one or another just because of the size, it's because this makes your HTML more semantic.

  I hope it helps!

  Other than those little details, you did a great job!

  Marked as helpful

  0