Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend Mentor | QR code component

Aymane Nouhairβ€’ 40

@AyamaneNouhair

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I think completed the project well ! I hope you will share me if there are some errors in the project . thank you

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have other suggestions about your code that might interest you.

HTML 🏷️:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

Alt text πŸ“·:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. πŸ“˜.

CSS 🎨:

  • The color of the paragraph element is unreadable because it is too light compared to its background. For example, change the color to hsl(220deg, 15%, 55%).

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1
Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @AyamaneNouhair!

Your project looks great!

I wouldn't say it's an error, but I think there's a small detail that can help you to improve your project:

  • Check the font-weight and colors of the text. Make sure you import the font-family from Google Fonts with all the weights used in this project. I noticed that you set font-weight: 700; to your <h2>, but it's not applying.

  • Also, since every project should have a <h1> and that bold text is the most important content on the screen, you can replace your <h2> with a <h1>. You don't use one or another just because of the size, it's because this makes your HTML more semantic.

I hope it helps!

Other than those little details, you did a great job!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord