Design comparison
Solution retrospective
I think completed the project well ! I hope you will share me if there are some errors in the project . thank you
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there π. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
HTML π·οΈ:
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
Alt text π·:
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. π.
CSS π¨:
- The color of the paragraph element is unreadable because it is too light compared to its background. For example, change the color to
hsl(220deg, 15%, 55%)
.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1 - Use semantic elements such as
- @danielmrz-devPosted 11 months ago
Hello @AyamaneNouhair!
Your project looks great!
I wouldn't say it's an error, but I think there's a small detail that can help you to improve your project:
-
Check the
font-weight
andcolors
of the text. Make sure you import thefont-family
from Google Fonts with all theweights
used in this project. I noticed that you setfont-weight: 700;
to your<h2>
, but it's not applying. -
Also, since every project should have a
<h1>
and that bold text is the most important content on the screen, you can replace your<h2>
with a<h1>
. You don't use one or another just because of the size, it's because this makes your HTML more semantic.
I hope it helps!
Other than those little details, you did a great job!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord