Skip to content
Submitted over 2 years ago

Frontend Mentor | QR code component

Yakeru•260
@ykru6
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

How organize and clean my code was? Is my code a clutter, or inefficient? What could I've done better next time? What should I acknowledge in order to up my skills in CSS?

By the way, if the Web URL has problem then it's my bad, because this is my first time use Github. And this is my 2nd attempt at upload this solution, since the web crashed somehow...

Community feedback

  • Danilo Arcidiacono•120
    @daniloarcidiaconoPosted over 2 years ago

    Hello, here are some things that come to mind:

    1. Use BEM notation consistently to name your CSS classes (block__element--modifier);

    2. The font is imported in HTML but it's not used in CSS;

    3. Do not select h1, h4, p tags directly. Either add a class to such tags or use a CSS combinator to target them;

    4. Use max-width for the card. Also don't set a fixed height.

    5. Use CSS custom properties to centralize constants, like colors;

    6. Put your CSS files in a dedicated folder;

    0
    Yakeru•260
    @ykru6Posted over 2 years ago

    @daniloarcidiacono Thank you friend.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord