@Islandstone89
Posted
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a<main>. -
The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."
-
I would change the heading to a
<h2>- a page should only have one<h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Including a CSS Reset at the top is good practice.
-
I like to add
1remofpaddingon thebody, to ensure the card doesn't touch the edges on small screens. -
Remove all widths and heights in
px. -
Add a
max-widthof around20remon the card, to prevent it from getting too wide on larger screens. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
letter-spacingmust also never be inpx. You can useem, where1emequals the element's font size. -
Since all of the text should be centered, you only need to set
text-align: centeron the body, and remove it elsewhere. The children will inherit the value. -
On the image, add
display: blockandmax-width: 100%- the max-width prevents it from overflowing its container.
Marked as helpful
@gaut123456
Posted
@Islandstone89 Thanks for your answer it was very helpful, I made the changes you mentioned! Have a good day.
@Islandstone89
Posted
@gaut123456 Happy to help! :)
