Frontend Mentor - QR Code Challenge

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • In order to fix the accessibility issues, you need to replace <div class="container"> with the <main> tag and <div class="attribution"> with the <footer> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  @ecemgo Thanks for helping me :) I fixed my code according to your advice.

  1
• 

  Amer Shah•260

  @fggdbdsbfdPosted over 1 year ago

  I'd be happy to give you some advice on the topic of landmarks in HTML documents! Here are some tips, presented in bullet points with a professional tone and a few helpful emojis:

  -🏠 Every good HTML document should have a main landmark! This landmark helps users understand the structure of the page and navigate it more easily.

  -📌 The main landmark should typically be the <main> element. This element should contain the main content of the page, such as articles, posts, or product listings.

  -🔎 You can use ARIA attributes to help identify your main landmark and make it more accessible to users who rely on assistive technologies.

  -🧐 Remember that other landmarks, such as <header>, <nav>, <aside>, and <footer>, can also be helpful for organizing your content and making it easier to navigate.

  -💻 When designing your HTML document, it's important to consider the needs of all users, including those with disabilities. By using proper landmarks and ARIA attributes, you can make your site more accessible and user-friendly for everyone.

  -I hope these tips help you create an organized and accessible HTML document with a clear main landmark! If you have any more questions, feel free to ask.

  Marked as helpful

  1

  ---

  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  @fggdbdsbfd Thanks for giving me accessibility advice :) I'll reach to you if I need any help.

  1