Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend Mentor - QR Code Challenge

md_mark 180

@mohdahsanrazakhan

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

  • In order to fix the accessibility issues, you need to replace <div class="container"> with the <main> tag and <div class="attribution"> with the <footer> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

Hope I am helpful. :)

Marked as helpful

1

md_mark 180

@mohdahsanrazakhan

Posted

@ecemgo Thanks for helping me :) I fixed my code according to your advice.

1
Amer Shah 260

@fggdbdsbfd

Posted

I'd be happy to give you some advice on the topic of landmarks in HTML documents! Here are some tips, presented in bullet points with a professional tone and a few helpful emojis:

-🏠 Every good HTML document should have a main landmark! This landmark helps users understand the structure of the page and navigate it more easily.

-📌 The main landmark should typically be the <main> element. This element should contain the main content of the page, such as articles, posts, or product listings.

-🔎 You can use ARIA attributes to help identify your main landmark and make it more accessible to users who rely on assistive technologies.

-🧐 Remember that other landmarks, such as <header>, <nav>, <aside>, and <footer>, can also be helpful for organizing your content and making it easier to navigate.

-💻 When designing your HTML document, it's important to consider the needs of all users, including those with disabilities. By using proper landmarks and ARIA attributes, you can make your site more accessible and user-friendly for everyone.

-I hope these tips help you create an organized and accessible HTML document with a clear main landmark! If you have any more questions, feel free to ask.

Marked as helpful

1

md_mark 180

@mohdahsanrazakhan

Posted

@fggdbdsbfd Thanks for giving me accessibility advice :) I'll reach to you if I need any help.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord