Design comparison
Solution retrospective
Responsiveness: I'm really proud of how responsive the site turned out. It works well across different screen sizes, ensuring a good user experience on both mobile and desktop devices.
What challenges did you encounter, and how did you overcome them?During the development of this project, I found that everything went quite smoothly. I didn't encounter any significant challenges that impeded my progress. I was able to follow the design specifications and implement the functionality without any major obstacles. This positive experience allowed me to focus on refining the details and ensuring the final product met the high standards I set for myself.
What specific areas of your project would you like help with?I feel confident about the current state of my project and don’t have any specific areas where I need help at the moment. However, I am aware of the importance of writing clean code and using the provided fonts, and I’ll make sure to pay extra attention to these aspects in future projects. If any issues do arise, I’m prepared to tackle them on my own as they come up.
Community feedback
- @StroudyPosted 2 months ago
Hey, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - It is best practice to have a
<main>
tag inside your body highlighting the main section. - Your heading elements are not in a sequentially-descending order,
<h1>``<h4>``<h2>
, Should be<h1>``<h2>``<h3>``<h4>
, You can have multiple<h2>
but they have to be in order, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies. - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
- You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- It is best practice to use
margin-inline: auto;
to center left and right then than justmargin: auto;
, You can center the height by using this code snippet
min-height: 100svh; display: flex; justify-content: center; flex-direction: column;
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
Marked as helpful1@IhdirPosted 2 months ago@Stroudy Thank you so much for your help and I'll definitely improve and work on what you said next time.
1 - Missing a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord