Frontend Mentor - Product preview card

Community feedback

• 

  cacosted•570

  @cacostedPosted over 2 years ago

  Hello yakeru, your solution looks nice, and the responsive works well. I have some suggestions that could improve your code.

  First, I don't know why you have some javaScript files that only print "hello world" but if you are not using them you should remove them or "ignore" them with the .gitignore file.

  In other hand, I notice that you used a <picture> tag to show both images on the card, this is a good approach but it doesn't work as you think. In the way you do it, both images are downloaded when the page loads; but you can load only the images only when they are needed (when screen size changes) using this tag <source media="(min-width: 700px)" srcset="image.jpg"> inside the <picture>.

  In this way, the pages only download the image that is used, and this can improve the user experience in large projects.

  0
• 

  Yakeru•260

  @ykru6Posted over 2 years ago

  bro the screenshot do mess up the solution :v

  0