Submitted about 2 years ago
Frontend Mentor - Product preview card component solution
@Chris-ai
Design comparison
SolutionDesign
Solution retrospective
Can I have some code review about this solution? What could I do better in CSS/HTML structure to make it more proffesional?
Community feedback
- @hmadamkPosted about 2 years ago
- great work, I really liked the transition on the wrapper, cool!
- make sure that all of your page is contained by a landmark examples of landmarks are
header for the top section main for your main section section with aria-label to describe why you added this section footer for the bottom section
the main landmark is required an represent the most important section in your case where you use a card you should wrap it inside of main to give it semantic meaning
- hope this helped
Marked as helpful1@Chris-aiPosted about 2 years ago@hmadamk Thank you for your feedback! I will focus on this at my next solution.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord