front-end mentor product preview card component exercise

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Add a border-radius along with overflow: hidden to your component's container to better match the FEM design.

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  Centering in CSS

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  0

  ---

  

  andy•170

  @monstermaashPosted about 2 years ago

  hey @vcarames !

  thanks for your feedback, it helped a lot!

  Cheers! 🥳🎉

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @monstermaash

  I am glad that I was able to help you out!

  Keep it up!

  0
• 

  cryptososso•150

  @cryptosossoPosted about 2 years ago

  You can check this site to center the main element https://moderncss.dev/complete-guide-to-centering-in-css/#xy-grid-solution

  0