Saulius K.• 560
@TH3RIV
Posted
Hi, @ByProxy66! To me it looks pretty good.
The main issue I have with your project is that it does not contain landmarks (header, main, footer). Pretty sure a page content has to be wrapped in <main></main> landmark for it to recognise what is the main content of the page.
Therefore I would suggest doing the following:
- Wrap your card within
mainlandmarks. - Wrap your attribution within
footerlandmarks.
Hope this helps!
Marked as helpful
2
Mads Gregersen• 30
@ByProxy66
Posted
@TH3RIV Thank you. I absolutely 'forgot' that and I have to confess, that I need to do some reading up on landmarks. I wrapped the content, rather than the divs. I don't know if that's correct.
0
Saulius K.• 560
@TH3RIV
Posted
@ByProxy66 Your whole card should be wrapped within main tags.
<body>
<main>
Main Content (Card)
</main>
<footer>
Footer Content (Attribution)
</footer>
</body>
1
