Frontend Mentor | Product preview card component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag, <div class="title-content"> with the <p>, <div class="trademark-content"> with <h1>, <div class="discribe-content"> with <p> and wrap <div class="attribution"> within a footer tag to fix the accessibility issues.
  click here for more on web-accessibility and semantic html

  Replace the main tag <main> with a section tag instead.

  For a responsive content give .container a max-width value instead of a min-width value.

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  In the media query give, change the max-width value of .container, .img-main- a width of 50%, the img a width of 100% and the section a width of 50% and padding valye for all the sides. the max-width for .container in media queries should be 500px.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0