Frontend Mentor | Order summary card - html, CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi! 👋

  The site still using the SVG. I thought you were using png or jpg instead of svg.

  Regarding the background image. I made some changes to the CSS.

  body {
      font-family: 'Red Hat Display', sans-serif;
      font-size: 16px;
      line-height: 1.1;
      margin: 0;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
      background-image: url(./images/background-dekstop.svg);
      /* background-size: cover; */
      background-repeat: no-repeat;
      background-size: 100%;
  }
  

  I recommend adding the background-color. You should be able to find the color code on the style-guide.md.

  In this case, use interactive elements for any elements that have interactivity. Interactive elements can either be links or buttons.

  Keep in mind that, Anchor tags are for navigation, while the button elements are for actions like opening a modal, submitting a form, toggling element, etc.

  Hope you find this useful!

  P.S. I recommend keeping the .gitignore file to prevent the GitHub repository get filled with .DS_Store files.

  0

  ---

  

  Mario Lisbona•150

  @MarioLisbonaPosted over 2 years ago

  @vanzasetia Thanks so much for the tip!

  yes ur correct. I just realised that in finder the original.svg files were in the image folder but when i tried to view them in VSCode it would only display markup. So i think what i did was kinda redundant.

  Ok yes i noticed that the .DS_Store folder kept being added to my git repo. Ill do that now. thanks

  0