Frontend Mentor - Order summary card

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Bitu, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all margin from card class because with flex they are superfluous
  • use min-height: 100vh to container class instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @rauthbitu,

  Nice job on completing the challenge

  It mostly just spacing issues you can make the following changes to the values in the CSS file.

  .card {
      width: 100%;
      max-width: 350px;
  }
  
  .text {
      padding: 2rem;
  }
  .price {
      margin-top: 1rem;
  }
  

  remove the margin on the .text p. Hope this is helpful.

  Marked as helpful

  0