Design comparison
Solution retrospective
Messed up the flexbox when you go to down to very small resolutions. Tried fixing it but no success. Would love to know what how I could fix this.
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @maxted83, congratulations for your new solution!
๐ Youโve done really good work here putting everything together, Iโve some suggestions you can consider applying to your code:
1.Its not so good that you used
overflow: hidden
for the whole content, in this case this property is making the content get cropped when the component gets tiny. Instead of usingoverflow
to make the rounded borders useborder-radius
for each card.2.To make your solution even better and more responsive, you can create a media query to break the elements in the
pricing section
afterwidth: 350px
and make every content in a different row, saving space for low resolution devices.@media (max-width: 350px) { .pricing { display: flex; align-items: center; flex-direction: column; } }
โ๏ธ I hope this helps you and happy coding!
Marked as helpful1 - @AdrianoEscarabotePosted about 2 years ago
Hello @maxted83, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Document should have one main landmark, you could have put all the content inside the
main
tag click hereI noticed that there were two scrollbars on the page, to fix it I did the following:
* { margin: 0; padding: 0; box-sizing: border-box; }
The rest is really good! Hope it helps... ๐
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord