Skip to content
Submitted almost 2 years ago

Frontend Mentor | NFT preview card component

diegoweb3r•60
@diegoweb3r
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm getting better. Did faster than others, but i see that i need to study about responsive layouts.

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted almost 2 years ago

    Hi diegoweb3r, congrats🎉 on completing the challenge.

    • To learn responsivness you can explore freeCodeCamp take or check out this Free Short Course about Responsiveness.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use alt attribute as it is mentioned in your Accessibility Report. alt attribute is used for Screen readers technology. Why alt attribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :

    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    Hope you will find this Feedback Helpful.

    Marked as helpful
    0
    diegoweb3r•60
    @diegoweb3rPosted almost 2 years ago

    @atif-dev Hello, thank you so much. Your feedback made me grateful. I'm going to read your links and going to fix the problems!!!

    But, another question:

    I'm using main tag, right? about the github tip, i did the github pages, here: https://diegoweb3r.github.io/Frontend-Mentor-NFT-preview-card-component/

    1
    Atif Iqbal•3,200
    @atif-devPosted almost 2 years ago

    @diegoweb3r actually you have used following div outside the main tag.

    <div class="attribution">
    Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
    Coded by <a href="https://github.com/diegoweb3rx">Diego Web3r</a>.
</div>

    (that's why the warning appeared in Accessibility Report). Instead just do as:

    <footer class="attribution">
    Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
    Coded by <a href="https://github.com/diegoweb3rx">Diego Web3r</a>.
</footer>
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord