Design comparison
Solution retrospective
I hope I got the box-shadow property correctly. I also hope I was able to replicate the design correctly.
Community feedback
- @DavidMorgadePosted over 2 years ago
Hello! congrats on finishing the challenge!. Nice work with the component!
-
First of all seems that your image is not loading properly, this is because you are not defining the relative path in your background-image correctly, try with
background-image: url(./image-equilibrium.jpg);
. -
There is a bit easy way to center your component, instead of using
margin: auto auto
in the container, try giving flex to the parent element (the body), and center it, for example:
body { display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100vh; }
- And my final advice would be to start using relative units such as rems instead of px, using px is usually a bad practice and should be avoid!
Hope my feedback helps you in future projects!
Marked as helpful0@LooceePosted over 2 years ago@DavidMorgade thank you. I'd work on using rem more often.
1 -
- @sinjin25Posted over 2 years ago
Good job
I think your image is broke on the github deployment.
I was able to fix it on github by changing the url: url(..icon-view.svg) to url(icon-view.svg)
A bit of padding to the right of the avatar and a bit less margin on top of the decorative bar might get it a little closer
Marked as helpful0@LooceePosted over 2 years ago@sinjin25 thanks, i've done that. the image is visible now
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord