Submitted over 1 year ago
Frontend Mentor - Newsletter sign-up form with success message
@lastiwan89
Design comparison
SolutionDesign
Solution retrospective
please leave me comment for review this work. i want to improve my coding journey
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
LABELS 🔖:
input
elements wants alabel
associated with it properly, Currently thelabel
element you used in this form is not properly associated.
- A
<label>
is used to create a caption for a form control. The<label>
can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute
- Effective form
labels
are required to make forms accessible. The purpose ofform
elements such ascheckboxes
,radio
buttons,input
fields, etc, is often apparent to sighted users
- Even if the
form
element is not programmatically labeled. Screen readers users require useful formlabels
to identifyform
fields.
- Example:
<label class="large-label" for="user-name"> Your name </label> <input id="user-name" name="user-name" type="text" />
- You need to proper
for
attribute forlabel
and you need to associate that withinput
element usingid
andname
attribute.
- All the three attribute's value must want to be the same for proper association.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord