Frontend Mentor - Interactive pricing component

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. Layout in desktop is really good also almost like the design! Mobile state is fine, however, from mobile transitioning to tablet or to desktop size, the layout starts being hidden.

  Suggestions would be that:

  • adding a padding-bottom to the body tag so that there will be space from the layout to the side of the screen. You can see it is touching the bottom if you scale the width of your browser.
  • your slider and the checkbox should have their own visual indicator, adding an outline on their focus-visible state so that keyboard users will know where they are when navigating.
  • the checkbox could have used label. Example, clicking the monthly billing or yearly billing triggers the checkbox. That would be great, but if you were not to add it, make sure to add aria-label on the checkbox.
  • also, it could be great if the whole box is wrapped inside a form element. This will make the targeting of every input element easier if this were created as a usable app.
  • the attribution also is overlapping the content, the position: absolute causes this, but when I remove it, it is hidden now. Haven't solved that one out yet, but maybe you can tinker with it :>
  • the color of the "start my trial" text on mobile state changes and goes darker which is hard to read. Changing it to white would be really great.

  Still, great job on this.

  Marked as helpful

  0

  ---

  

  Dwi susilo•325

  @dwi312Posted about 3 years ago

  @pikamart thank you again for everything you pay attention to in very detail, this will increase my knowledge so that I can improve even more..

  0