Frontend Mentor - Interactive card details form

Community feedback

• 

  Ricky Hewitt•90

  @rickyhewittPosted over 1 year ago

  Great work!

  One thing I would note is that the desktop design seems to be incorrect, it is perhaps only using the mobile one.

  The other thing I noticed is that you could avoid duplication in your javascript for eventhandlers.

  For example, your existing code:

  document.querySelector("#name").addEventListener("keyup", checkErrorsOnPress);
  document.querySelector("#number").addEventListener("keyup", checkErrorsOnPress);
  document.querySelector("#mm").addEventListener("keyup", checkErrorsOnPress);
  document.querySelector("#yy").addEventListener("keyup", checkErrorsOnPress);
  document.querySelector("#cvc").addEventListener("keyup", checkErrorsOnPress);
  

  Could be replaced with either event delegation or a loop.

  const elements = document.getElementsByTagName("input");
  for (let i = 0; i < elements.length; i++) {
  elements[i].addEventListener("keyup", checkErrorsOnPress);
  }
  

  0