Frontend Mentor - Fylo landing page with two column layout

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  Hey @sumit-kr nice work on this one! It looks good! 🙌

  Here's some things you might like to think about:

  1. I would put the sections between the header and footer - this will just make the page structure easier for people to navigate. And in the same way I would put the list of links in the footer inside your ul in a nav. Again this just makes it easier for people.

  2. In the footer I saw that some of the icons are a bit squished. I prefer to use svgs directly in my HTML for this as it's a bit more flexible and easier to style. They can be a bit intimidating at first but are worth getting used to.

  3. For the forms don't forget that each input element must have a linked label element. This can be hidden using CSS if you don't want to show anything, but it must be there for accessibility reasons. Here's why: https://css-tricks.com/html-inputs-and-labels-a-love-story/

  But otherwise great work on this one and keep up the good efforts! 👍

  Cheers 👋

  1

  ---

  

  Sumit Kumar Das•70

  @sumit-kr-dasPosted over 3 years ago

  @dwhenson Thanks for your complement, i will try to solve all problems.

  0
• 

  TechnoSolution•125

  @MuhammadLaeeqPosted over 3 years ago

  good effort but you should focus on the layout of your design

  0

  ---

  

  Sumit Kumar Das•70

  @sumit-kr-dasPosted over 3 years ago

  @MuhammadLaeeq how to measure paddings and margins which gives us by frontendmentor ?

  0