front-end mentor four card feature section exercise

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Unless your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.

  • To properly center your content to your page, you will want to add the following to your body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  Centering in CSS

  • Your HTML is missing a header and main element to improve semantics and accessibility.

  • The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single h1 heading along with a span element.

  • The card titles are headings (you even gave them a heading class) they should be wrapped in a heading element.

  • Along with the blank Alt Tag, you also want to include the aria-hidden=“true” to your “icons” to fully remove them from assistive technology.

  • Using CSS Grid with Grid-Template-Areas will make things way easier when building the layout; it will give you full control of the layout.

  Here is an example of how it works: EXAMPLE

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0