Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend Mentor Challenge "qr-code-component-main"

zerozuckerβ€’ 50

@zerozuckerx

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


First challenge after a 3 month break, struggled a bit with getting the text into the right position, probably not necessary to create 2 wrapper divs

Community feedback

Adrianoβ€’ 34,090

@AdrianoEscarabote

Posted

Hi zerozucker, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

2- All page content should be contained by landmarks, you can understand better by clicking here: click here

We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:

<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...πŸ‘

Marked as helpful

1

zerozuckerβ€’ 50

@zerozuckerx

Posted

@AdrianoEscarabote thank you Adriano! I was not yet aware of the necessity to use these landmarks.

Do you mean replacing all px with rem, or which are the important ones that should be considered for responsiveness?

0
Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hi Zerozucker, congratulations on completing the challenge, great job! 😁

Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of texts
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

Hope this help! Happy coding πŸ˜‰

Marked as helpful

1

zerozuckerβ€’ 50

@zerozuckerx

Posted

@denielden Hello Deniel! Thank you so much for your reply.

I am aware that the divs containing the 2 text sections are not necessary, but I wasn't able to fit the text exactly the way it was displayed in the image of the challenge (e.g. "the next level" on the last row) while simultaneously trying to keep the text sizes proportional to each other. Would you have an idea how to manipulate the 2 different texts in order to tweak size, etc.?

I will implement the other optimizations and see how it goes! Much appreciated

1
Travolgi πŸ•β€’ 31,420

@denielden

Posted

@zerozuckerx You are welcome and keep it up :)

You can look at my solution... I used padding-inline to manipulate the space available for the text

1
Lucas πŸ‘Ύβ€’ 104,420

@correlucas

Posted

πŸ‘ΎHi @zerozuckerx, congratulations on your solution!

I’ve few suggestions for you that you can consider adding to your code:

1.Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

2.Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

3.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

4.Something that can be a time saver for you is to use a CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

5.If you’re not familiar to media queries and responsiveness, here’s a good resource to learn it: https://www.w3schools.com/css/css_rwd_mediaqueries.asp

✌️ I hope this helps you and happy coding!

Marked as helpful

1

zerozuckerβ€’ 50

@zerozuckerx

Posted

@correlucas Hey Lucas! Thanks for your reply, I will try to implement the changes!

#3: I wasn't sure how to fit the texts exactly the way they are displayed in the challenge image without putting them in seperate divs.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord