Frontend Mentor Challenge Order summary component
Design comparison
Solution retrospective
Hello!
I tried using BEM convention, but I'm sure I've made mistakes. Any suggestions/Tips/mistakes would be helpful.
Any suggestions regarding the Challenge will be Helpful.
Thank You.
Community feedback
- @DeolabestPosted about 2 years ago
Hey @khuranamanan, Congratulations on completing this challenge!
Here is my feedback:
-
It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here:
https://pixelsconverter.com/px-to-rem.
-
Here is the correct background color for the body
background-color: hsl(225, 100%, 94%);
-
The button is also missing this:
cursor: pointer;
Keep doing a good job!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord