Design comparison
SolutionDesign
Community feedback
- @bleyyannickPosted 10 months ago
Hello, your code is fine and the result looks pretty good ! Just be careful to better indent your code for readibility for later projects !
Marked as helpful1 - @AGutierrezRPosted 10 months ago
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Wrap the primary content within the
<main>
tag instead of using it as a standalone component like a<div>
. - All the content should be contained within landmarks. Every page minimally needs a
<main>
element. - Consider using
<span>
or<time>
instead of paragraphs for elements that are not actual paragraphs like Published....
CSS and Styling:
- Implement CSS custom properties to define and utilize project colors more easily.
- Instead of fixed widths, employ
max-width
andmin-width
for flexible and responsive design. - Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
Accessibility and Semantic HTML:
- The icons/illustration images are decorative, so their alt text must be empty:
alt=""
. - Profile image could benefit from a more descriptive alt text, like
alt="Headshot of Greg Hooper"
. - Maintain semantic HTML structure by using appropriate elements for their intended purposes.
- Ensure compliance with accessibility standards by avoiding redundant or unnecessary tags and utilizing appropriate landmark elements.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful0 - Wrap the primary content within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord