@nullpuppy
Posted
Right now everything is just in the body. I'd recommend putting the preview "card" in it's own div or section (I'd recommend getting familiar with semantic html, mostly for accessibility). That'll allow you to better position and style the component on the page. Depending on your experience with flexbox and grid, it might be worth experimenting more with them to get a better understanding of how they work, and what kind of nesting/etc is/isn't required.
Your javascript isn't working at the moment because you're using getElementById
, but then using a classname. You'll want to add something like id="shareButton"
to the element you want to use as the share button in the html, and reference in the css as #shareButton
.
Hope that helps!
Marked as helpful
@mverma45
Posted
@nullpuppy thanks for your feedback. I will work on it and get back to you.