Frontend Mentor | Advice generator app

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Hi Madhu

  Nice work so far. I love working with the keyboard and rarely uses the mouse. I am not be able to generate new advice as the diceBtn is a div. A div is not keyboard focusable.

  • since the advice are quotes, i think using a blockquorte can be an alternative
  • the method you used to display images on mobile and desktop (using display none) alternatively works , but is not among those considered for best practice. It involves uploading/downloading images that a user does not need - meaning that it wastes bandwidth making it expensive at the same time. Look into responsive image techniques
  • as a continuation from the above statement, the use of responsive images methods will eliminate the of the javascript (window.onresize). But on second thought that js could have been avoided as those classes could have been put in a media query especially the else part.

  happy coding

  Marked as helpful

  0