Submitted over 2 years ago
Frontend Mentor - 3-column preview card component
@Nitinbhojsingh
Design comparison
SolutionDesign
Solution retrospective
Answer 1. It's more difficult to set a grid line. Answer 2. to setting up box sizeing. Answer 3. Btw this challenge is very helpfull to improve my css skills.
Community feedback
- @denieldenPosted over 2 years ago
Hi Nitin, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - to make it look as close to the design as possible add
max-width:60rem
to.wrapper
class - remove all
margin
from.wrapper
class because with flex they are superfluous - add
justify-content: center
to the body to center the card horizontally
Overall you did well 😁 Hope this help!
0 - add
- Account deleted
hi there,
- change the wrapper grid-template-columns to
grid-template-columns: 300px 300px 300px
- give the body
justify-content:center;
to center the wrapper - check the HTML report to fix accessiblity issues
- i don't understand your questions can you explain more?
i hope this is helpful and goodluck
0 - change the wrapper grid-template-columns to
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord