Frontend Mentor | 3-column preview card component

Community feedback

• 

  Mamadou Mar•550

  @Mar1362Posted almost 2 years ago

  Hi, i appreciate all your 8 months work but you missed the hover design of the 'learn more' buttons. if you don't understand the active-state design you can go preview the site of mine. your tablette view(768px * 600px) is terrible and doesn't respect the design. the border radius doesn't match the design too on mobile views and your footer hover the content. you have to fix all of that and we are open for any question, feel free to ask we will be glad to answer.

  Also, here are some suggestions:

  • use a semantic html instead of divs for your different sections
  • for your icon images you should add aria-hidden='true' attribute or role='presentation' attribute to the img tag since these images are purely decorative.
  • you have to avoid this kind of code : <button style="color: hsl(31, 77%, 52%);">Learn More</button>. in fact, the style attribute have priority over any css file. as a consequence, whenever you want to change the color at your css file you won't be able to. you can use '!important' css value, just in case you need to force overrides at your css file.
  • you should use mobile first approach

  happy coding! feel free to ask any question we will be glad to answer.

  Friendly!

  Marked as helpful

  1

  ---

  

  Lucas Costa•50

  @lcscostadevPosted almost 2 years ago

  @Mar1362 Hi, thank you for my mistakes you pointed out, honestly i didnt read the rules of the challenge because i was too tired yesterday, so today i rewrote all the code for the mobile first, removed the inline style from html, and fixed the hover (i didnt saw the rule that says it need to be a specific one)... anyway, you helped alot, thank you!

  0

  

  Mamadou Mar•550

  @Mar1362Posted almost 2 years ago

  @lcscostadev you're welcome, you can mark my first comment as helpfull if you want. you can ask any question you wish.

  friendly !

  1