Submitted about 2 years ago
Frontend Mentor - 3-column preview card component
@Luis-Olivero
Design comparison
SolutionDesign
Solution retrospective
Here is my second attempt after all your feedback! Thank you all for the help and advice given.
Community feedback
- @PhoenixDev22Posted about 2 years ago
Hello Luis-Olivero,
Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:
HTML
- Page should have at least one level heading. You can have
<h1>
visually hidden withsr-only
.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site usingtarget=”_blank”
attribute , you can expose your site to performance and security issues.
- Add
border-radius
andoverflow hidden
to the main container that wraps the three cards so you don't have to set it to individual corners.
Aside these, great job on this one. Hopefully this feedback helps.
Marked as helpful0 - Page should have at least one level heading. You can have
- @Cosenza26Posted about 2 years ago
I would recommend to add some padding after each description
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord