Frontend Mentor - Social links profile

Community feedback

• 

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  Hey again, Looking forward to going through this solution with you, I can see you already have made improvements, Few more things

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,

  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,

  • You should add a font-display: swap; property to your @font-face, Leverage the font-display CSS feature to ensure that text is user-visible while web fonts are loading, Increasing performance.

  • You wont need to use display: flex on every element if the parent has one because it will inherit it,

  • On the body, It is best practice to use margin-inline: auto; to center left and right then just margin: auto;, You can center the height by using this code snippet

    min-height: 100svh;
    display: flex;
    justify-content: center;
    flex-direction: column;
  

  I hope you found some of this information helpful, Great solution and you should be proud, Hope you have a good day, Happy Coding!

  0