Design comparison
Solution retrospective
This is my first site, I would like to have your opinion I am a total beginner
Community feedback
- @pikapikamartPosted over 3 years ago
Great work on you first challenge here in FEM.
The layout is good in desktop and mobile view is good.
Suggestions would be that
-. Instead of adding
height: 100vh
in your body tag, you can specify onlymin-height: 100vh
. This way, it will make sure that your website will have a minimum height, based on the viewport, or the screen of the user.- Also your footer social media icons, it will be awesome if you put those element inside an
a
tag. Because those are links right, so nesting them or putting them inside ana
tag will be really good.
Just keep doing these challenges and also reading or studying more about html, elements and it will really help you. Also freecodecamp.org is a great website to study a lot in different fields. Good job ^^
0 - Also your footer social media icons, it will be awesome if you put those element inside an
- @Batareika007Posted over 3 years ago
Hi Alex! I think for beginner you did a very nice job. the webpage responsive, only need to make some cosmetic with positions. It's look great on mobile. More practices and I would like to see more of your future works, well done !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord