Front end mentor challenge

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  
  .box-container {
      /* margin: 120px auto; */
  }
  

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1

  ---

  

  Caio Ferreira•60

  @caiof9Posted almost 2 years ago

  @MelvinAguilar Thanks for the comment and suggestions. I'll study more about it. :D

  1