fourth frontend mentor project

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Faizan, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • remove min-height from main class and set width: 20rem
  • remove min-height and width from main-one class because they are unnecessary
  • remove all margin from main class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁

  Marked as helpful

  1
• 

  Remtaine•360

  @remtainePosted over 2 years ago

  Looks nice, especially at the 375 and 1440px breakpoints specified. However, some improvement can be done at the other screen sizes in between. Increasing your media query breakpoint from 480px would be helpful. Right now most screen-sizes between 480px and around 1000px don't look good. Did you specify a large margin? That might also be the problem

  Marked as helpful

  0