four_card_section - made with pure html & css-grid, flexbox & medQuery

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Dfcuevas 👋🏻

  I just have a couple of suggestion for the project.

  • The icons, should have aria-hidden="true”, because they're for decoration. You can read more about aria-hidden here.
  • Although it works fine in this small project, but in general, avoid using floats, since they can cause some unwanted bugs and are pretty hard to debug. Here's an alternative approach:

  .container-box {
      background: white;
      padding: 35px;
      border-radius: 10px;
      box-shadow: 1px 9px 10px 3px #D8D8D8;
      display: flex;
      flex-direction: column;
  }
  

  I added the last two lines to .container-box and you should add this line align-self: flex-end; to .container-box img;

  I hope this was helpful 👨🏻‍💻 all in all, you did a great job with responsiveness, well done. Cheers 👾

  Marked as helpful

  0

  ---

  

  Diego Fernando Cuevas Amaya•290

  @DfcuevasPosted about 3 years ago

  @kens-visuals, Thanks for your feedback, i appreciate soo much!

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @Dfcuevas you're welcome, glad to be helpful 😇

  0