Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @Hussain5325, Congratulations on completing this challenge!
Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:
You've done the design for the wrong image, when you download the starter files the folder comes with 3 files (preview card, desktop and mobile) you've created the solution based on the
preview
and you should consider only themobile + desktop images
.Remove thebackground-color
from the container and add it to thebody
to make sure this color background will display it full screen.Improve the semantic replacing the
<div>
used for the four cards and use instead<article>
that is a better tag, remember that<div>
doesn’t have any effective meaning is just a block elements, so for big block of elements use semantic tags.✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord