Design comparison
Solution retrospective
I hope you can give me your opinion of this work, thank you
Community feedback
- @MojtabaMosaviPosted over 3 years ago
Hi!, nice job, things to improve:
1- Regarding you markup, you're using to h1 for it, it's totally ok but you can also achieve the same behavior with one, you can achieve through either a br tag or max-width on it.
-
The card are not interactive therefore there is no need for the hover efftect.
-
I recomand you spend some time studying naming conventions and start learning one because it makes your markup much more reusable and readable, my favorite is BEM.
Keep coding :)
1@jorsuapPosted over 3 years ago@MojtabaMosavi Thank you very much for your recommendation, I did not know the BEM methodology and it seemed very good to have a more ordered code, again thanks
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord