Design comparison
Solution retrospective
Hi, I am happy to see you here. If you see any thing wrong in my code leave a comment below and thanks you help me to improve myself.
Community feedback
- @AbhijitSarodePosted almost 3 years ago
Hi Abdullah,
Your code seems to be well written, but I would suggest 'grid-template-areas' to layout elements in your grid.
While using measurement units go for responsive units like rem, em, %, vh, vw, ch etc instead of px or pt but be aware of the additive nature of some responsive units.
It's a personal choice but when using colors you can opt for global root variables so that in future if you ever need to change color then it becomes very easy to do so.
Try to be specific when it comes to images 'alt' descriptions
Hope this helps
Marked as helpful0@9dorghamPosted almost 3 years ago@AbhijitSarode You are right. Thanks! I heard before about using variables for global values in design ,but forgive me as you can see there isn't many colors in this design. Your are right I should use variables in designs to make enhancement easier. Thanks!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord