Four-card-feature-section-master

Community feedback

• 

  Mirjax2000•680

  @Mirjax2000Posted 8 months ago

  page icon karma, i noticed. Nice one.

  Html - too many divs. Use other elements with purpose. Header,main,footer,aside,section,article and many others. It helps browser better understand what is he displaying, also good for readers and also it helps better evaluate your page with SEO. Then you have better score and your site will be displayed higher.

  --root colors:

  :root {
      /* Primary  */
      --Red: hsl(0, 78%, 62%) ;
      --Cyan: hsl(180, 62%, 55%) ;
  }
  

  What happened if your designer or contrator or you will decide that color hsl(0, 78%, 62%) have to change to green? so your variable --red: will be green. And that is a mess. use something neutral for that, for example

  :root {
      /* Primary  */
      --header: hsl(0, 78%, 62%) ;
      --paragraph: hsl(180, 62%, 55%) ;
      --border-calculator:blue;
      --border-karma:yellow;
      --border-superviser: darkgreen;
      --border-teambuilder:red;
  }
  

  I like your flexbox styling.

  see you

  Marked as helpful

  0

  ---

  

  abderrahmane bnd•150

  @abderrahmanebndPosted 8 months ago

  hey Mirjax, i liked the idea of changing the names of variables , but i just copied it from the given style file , Thanks bro.

  1