@tesla-ambassador
Posted
Hey Rai_Sama, I am impressed that you managed to figure out what was wrong with the cards, I was actually going to point out that it was the max-width property but it seems like you were already working on it. This is a very great solution, it is really smooth with it's responsiveness... I like it. Heres a thing or two:
- You might want to include a <main> landmark and you might also want to contain your divs in landmarks. In your case, you could just enclose all your divs in the <main> you'll be hitting two birds with one stone. This will improve your website's accessibility and resolve most of your accessibility issues! Happy coding! 💪
Marked as helpful
@raisama21
Posted
@tesla-ambassador I replaced the .container <div> with the <main>, I hope it works . Thanks for your feedback.
@tesla-ambassador
Posted
@raisama21 I have seen it! You should separate the <header> from the main. The header shouldn't be a child of <main> it should look more like this
<header> #header-content </header>
<main> #main-content </main>
<footer> #footer-content </footer>
Let me know how it goes!
Marked as helpful
@raisama21
Posted
@tesla-ambassador How do I update the challenge here in frontend mentor I updated the code in github nut it is still showing the accessibility issue?
@tesla-ambassador
Posted
@raisama21 You should ask for an update on your report and that should fix it
