Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello , congratulations on your first solution!
Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:
1.Improve the semantic replacing the
<div>
used for the four cards and use instead<article>
that is a better tag, remember that<div>
doesn’t have any effective meaning is just a block elements, so for big block of elements use semantic tags.This a good resource to understand more aboutsemantic tags
:https://www.w3schools.com/html/html5_semantic_elements.asp
2.Replace the
<span>
containing the main title with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.✌️ I hope this helps you and happy coding!
Marked as helpful0 - @AbdellahArsPosted about 2 years ago
yes it's very helpful and i appreciate your help. thanks for that and happy coding to you too.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord