four-card-feature-section with Flexbox

Community feedback

• 

  drallas•375

  @DrallasPosted over 3 years ago

  Hello Hachi

  Well done Hachi mostly it looks pretty much like the design, but 'the devil is in the details'! It's also recommended to use rem and not px value for accessibility On my 38" screen the card grow really big when I take it fullscreen. Perhaps limit the max size of the cards a bit..

  Greetings... Drallas

  1

  ---

  

  Hachi•155

  @hachi-opsPosted over 3 years ago

  @Drallas thank you for pointing this out. I didn't think of it. You are absolutely right, applying relative units for fonts and/or max-width for the cards would make much more sense for big screens.

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey great work there, the layout seems fine just the widths of the card right. Also, upon seeing your code

      border-top: 4px solid;
      border-right: 1px solid none;
      border-left: 1px solid none;
      border-bottom: 1px solid none;
  

  instead of multiple assignment, you could make use of just border: 1px solid transparent none does not work in there, and I suppose you are making it invisible right so transparent is the value. Then after that you could just override the border-top via a declaration in their respective color coded card like in your .cyan class, border-top: 4px solid cyan something like that just to avoid multiple declarations^

  1