darryncodes• 6,430
@darryncodes
Posted
Hi Afra,
Really good solution, well done!
Two bits of feedback from me:
- you could clear your accessibility report if you changed
<div class="container">to<main class="container">. It's really important to use semantic html - i'm viewing your solution on a really wide monitor. The middle column is quite stretched and the other two are squashed and overall it's not centred. I think a better choice for this solution would be CSS Grid
But overall you pretty much nailed it, with a few tweaks it could be perfect 🤙
0
afra_tariq• 40
@myNameIsArfa
Posted
@darryncodes first of all I appreciate your feedback. Its realy helpfull for me. Yeah i agree, with css grid it would be more easy and manageable.
0
