Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
i make the mobile :)
What challenges did you encounter, and how did you overcome them?doing the mobile
What specific areas of your project would you like help with?if you have sugestions for the mobile and youd like to help me, dont esitate
Community feedback
- @moadavouPosted 7 months ago
Great work! Here are a few suggestions to improve your code:
<h1>
has to come before<h2>
. h1-h6 is used to create a table of contents (of sorts) for the page. It can be very confusing if they are not in order. You can wrap the first or second part of the title in a<span>
to style it.
- The cards are self-contained pieces of content. You should therefore use
<article>
instead of<div>
to contain them.
- You have a lot of repeated CSS for the cards. You can target multiple CSS classes at once, or take advantage of inheritance and put the styles on the
.card
class.
- You are meant to use
grid
and notflexbox
to position the cards.
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord