Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

four-card-features

@codingwithriha

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would like your sincere feedback.

Community feedback

@Johndiddles

Posted

The link to the github code now works but the live link shows the content of your gh-pages branch. I think you have to go to your settings on this repo and click on pages, then change the source to main (which is the branch that has your code) and then click save. I think this should fix it.

Marked as helpful

0

@Johndiddles

Posted

Hi Riha! I checked back and saw that you've fixed your live link. That's great.

Your solution is nicely done. I saw that you used margins to give your flex items some spaces between them. That works. But a better practice is to give the containing div with the display of flex a gap attribute. something like this;

.container {
  display: flex;
  gap: 2em;
}

this separates all of the flex items by 2em both horizontally and vertically.

You can also consider using relative units such as 'em', 'rem' instead of px for your sizes especially your fonts.

Every other thing looks great. Good job! Cheers 🍻

0

@Johndiddles

Posted

Hi Riha, how're you doing?

It seems your links are broken or you probably made the github repo private or the repo is deleted. You might want to check that out.

0

@codingwithriha

Posted

@Johndiddles Is this available now?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord