four-card-features

Community feedback

• 

  John_diddles•470

  @JohndiddlesPosted over 2 years ago

  The link to the github code now works but the live link shows the content of your gh-pages branch. I think you have to go to your settings on this repo and click on pages, then change the source to main (which is the branch that has your code) and then click save. I think this should fix it.

  Marked as helpful

  0
• 

  John_diddles•470

  @JohndiddlesPosted over 2 years ago

  Hi Riha! I checked back and saw that you've fixed your live link. That's great.

  Your solution is nicely done. I saw that you used margins to give your flex items some spaces between them. That works. But a better practice is to give the containing div with the display of flex a gap attribute. something like this;

  .container {
    display: flex;
    gap: 2em;
  }
  

  this separates all of the flex items by 2em both horizontally and vertically.

  You can also consider using relative units such as 'em', 'rem' instead of px for your sizes especially your fonts.

  Every other thing looks great. Good job! Cheers 🍻

  0
• 

  John_diddles•470

  @JohndiddlesPosted over 2 years ago

  Hi Riha, how're you doing?

  It seems your links are broken or you probably made the github repo private or the repo is deleted. You might want to check that out.

  0

  ---

  

  Riha Shehzadi•80

  @codingwithrihaPosted over 2 years ago

  @Johndiddles Is this available now?

  0