four-card-feature responsive, CSS Flexbox and Grid, Semantic

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The aria-label="main" is not needed ⚠️ in the main element.

  • This LINK should instead be a header ⚠️ element.

  • The “icons” in this component are purely decorative⚠️. Their alt tag should be left blank to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • There is no need to have separate stylesheets ⚠️as it can affect site performance. Instead have on singles stylesheet ✅.

  • NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a px to rem/ em converter in your code editor.

  html {
    font-size: 62.5%;
  }
  

  More Info:📚

  Should I change the default HTML font-size to 62.5%?

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  1

  ---

  

  Michel Moreira•300

  @michel-moreiraPosted almost 2 years ago

  @vcarames thanks! I'll check out the links you shared and appreciate the time you spent on my solution and this valuable feedback.

  I didn't know that separate stylesheets can cause any lack of performance.

  And about the html font size I need to learn more, there is a lot of uncertain information in my searches.

  1
• 

  Bilal Türkmen•340

  @bilalturkmenPosted almost 2 years ago

  header, main and footer tags are parent elements of a document structure. I think it would be more semantic to use section as children element inside them.

  1

  ---

  

  Michel Moreira•300

  @michel-moreiraPosted almost 2 years ago

  @bilalturkmen thank you, I really appreciate your suggestion and I'm reviewing the structure and making the necessary changes

  1