Design comparison
Solution retrospective
I just finished another project, I believe this has been the best I've done so far in frontend mentor! with each project I see my progress. With discipline and a lot of study I will reach my goal!
Feel free to look at my code and comment, I'm still getting familiar with frontend mentor, but soon I'll answer your help in the comments.
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To give your HTML code structure, you want to set up your code in the following manner:
<body> <header></header> <main> <section> <div class="supervisor-card"></div> <div class="team-card"></div> <div class="karma-card"></div> <div class="calculator-card"></div> </section> </main> </body>
The Header Element represents the your site’s introductory content.
The Main Element identifies the main content of your content..
The Section Element is used to wrap content that is related to each other, which these four cards are.
Lastly, since none of the cards can stand on their own, a simple Div will do for each card.
-
The Article Element is not the best choice for wrapping these card components. In order to use the Article Element the components need to be able to make sense on its own and be independently distributable (can be used in on another site). These card components cannot do neither. Instead, you want to wrap each individual testimonial component in a Div and give them a class.
-
The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single <h1> Heading along with a Span Element.
-
The icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord