Design comparison
Solution retrospective
Found it a bit tricky to do the border at the top of the cards, was the way I did it the best/most efficient?
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
Regarding your question,
The way you did the border is correct.
-
The
main
element should only be wrapping the cards, since that is the main content of page. -
The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single
h1
heading along with aspan
element.
- The
article
element is not the best choice for wrapping these cards. In order to use thearticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site).
- The “icons” serve no other purpose than to be decorative; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Using
CSS Grid
withGrid-Template-Areas
will make things way easier when building the layout; it will give you full control of the layout.
Here is an example of how it works: EXAMPLE
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord