Design comparison
SolutionDesign
Solution retrospective
Any feedback is appreciated. Thanks for your attention.
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, great work on this one. Both layout in desktop and mobile is good. No issue when resizing.
Just one little suggestion on the markup.
- I see that you are using 2 h1 in the header tag, which I think is not really good. Avoid using multiple h1 okay. Because it can causes problems for other users who uses screen readers. Instead of using 2 h1 to make that 2 rowed line. Use only 1 h1, then just wrap the text
Powered by Technology
in a span inside of the h1. This way is more clean and you avoid using that 2 h1.
Overall, great work on this one^^
1 - I see that you are using 2 h1 in the header tag, which I think is not really good. Avoid using multiple h1 okay. Because it can causes problems for other users who uses screen readers. Instead of using 2 h1 to make that 2 rowed line. Use only 1 h1, then just wrap the text
- @szcompanyPosted over 3 years ago
Thanks so much for your feedback. I really do appreciate it, and will fix the problem.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord