Design comparison
SolutionDesign
Community feedback
- @mattstuddertPosted almost 5 years ago
Nice work on this challenge and congrats on submitting your first challenge! π
Here are a few pointers after taking a look at your code:
- I would avoid using
position: absolute;
for layout purposes. Using it removes the element from the flow of the document and so you can easily run into issues. Instead, I'd focus on Flexbox or Grid. I see you're using some Flexbox, so I'd recommend sticking with that for now. - I'd also recommend not using IDs for styling purposes. They're too specific and can't be reused on the same HTML document. Instead, I'd stick with class, attribute, pseudo and type selectors.
- It looks like you didn't push the
/images
directory to GitHub, so the images aren't showing.
I hope these tips help. Keep up the great work! π
1@just-a-devguyPosted almost 5 years ago@mattstuddert Thanks for the feedback. I've not been on for a while. I will go ahead and make the modifications. I truly appreciate the feedback. Thanks a bunch.
0 - I would avoid using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord