Four Cards

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Nice work on this challenge and congrats on submitting your first challenge! 👍

  Here are a few pointers after taking a look at your code:

  • I would avoid using position: absolute; for layout purposes. Using it removes the element from the flow of the document and so you can easily run into issues. Instead, I'd focus on Flexbox or Grid. I see you're using some Flexbox, so I'd recommend sticking with that for now.
  • I'd also recommend not using IDs for styling purposes. They're too specific and can't be reused on the same HTML document. Instead, I'd stick with class, attribute, pseudo and type selectors.
  • It looks like you didn't push the /images directory to GitHub, so the images aren't showing.

  I hope these tips help. Keep up the great work! 👍

  1

  ---

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 5 years ago

  @mattstuddert Thanks for the feedback. I've not been on for a while. I will go ahead and make the modifications. I truly appreciate the feedback. Thanks a bunch.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @adluders you’re welcome!

  1