Design comparison
Solution retrospective
Hello, I've just completed this four card feature using CSS Grid, flexbox, and media query to make this website responsive. I will appreciate all the feedback and your advice. Also I'm open to any suggestion how could I improve as Front-end devs.
Thank you,
Community feedback
- @LysitheaDarkKnightPosted over 1 year ago
Hello, how are you? Good job on completing the challenge!
For these 2 pieces of code:
<h1 class="fw-regular">Reliable, efficient delivery</h1> <h1 class="fw-bold">Powered by Technology</h1>
You can just use one
<h1>
for both of these titles! You can make him break him by using<br>
or settingmax-width
to the h1 element. This is useful to save a line of code!Happy coding!
Marked as helpful0@jeffabenojaPosted over 1 year ago@LysitheaDarkKnight Hello there, thank you for giving me this information.
1 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS β οΈ:
- This solution has generated accessibility error report due to skipping heading levels which warn us as "Heading levels should only increase by one"
- We want to avoid skipping heading levels, make sure to start with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more π
- Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord