Skip to content
Submitted 7 months ago

Four Card Solution using Flexbox and CSS grid

ikethedev•260
@ikethedev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I would use a framework like tailwind

What challenges did you encounter, and how did you overcome them?

No challenges

What specific areas of your project would you like help with?

Nothing specific but I am always open to improvement

Community feedback

  • Moa Davou•310
    @moadavouPosted 7 months ago

    Great work on this project! 🎉 Here are a few suggestions for improvements:

    HTML

    • You have a h3 before your h1. This is very confusing for accessibility since the h1-h6 is used as a table of contents.
    • The header tag should not be included in the main tag.

    CSS

    • Never use px for font-size or line-height. This makes it impossible for users to scale the font and is therefore bad for accessibility.
    • Quite a few colors are wrong. Make sure that you take a closer look at the design file.
    • Don't use a set px width for the cards. This is bad practice for making responsive sites. Use min-width instead.
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord